Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST
What happened:
Probably need to think about whether do we even need to do anything in the controller as part of unregistration.
Server deletes the namespace and it should all the resources in that namespaces but we may want to clean up the resources if any created by manager. i see at least service account (Please see https://github.com/keikoproj/manager/issues/12 , config map at the moment.
But, To do this, we must add the finalizer to the secret which is being created as part of registration so when server deletes the namespace it do not delete the secret before controller takes care of cleaning the resources in the target cluster
What you expected to happen:
All the resources related to target cluster must be cleaned whether its inside manger control plane cluster or target cluster.
How to reproduce it (as minimally and precisely as possible):
Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST
What happened: Probably need to think about whether do we even need to do anything in the controller as part of unregistration.
Server deletes the namespace and it should all the resources in that namespaces but we may want to clean up the resources if any created by manager. i see at least service account (Please see https://github.com/keikoproj/manager/issues/12 , config map at the moment.
But, To do this, we must add the finalizer to the secret which is being created as part of registration so when server deletes the namespace it do not delete the secret before controller takes care of cleaning the resources in the target cluster
What you expected to happen: All the resources related to target cluster must be cleaned whether its inside manger control plane cluster or target cluster.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
Other debugging information (if applicable):
$ kubectl logs