search

keikoproj / upgrade-manager

Reliable, extensible rolling-upgrades of Autoscaling groups in Kubernetes
Apache License 2.0
141 stars 45 forks source link

Add ignoreDrainFailure and DrainTimeout as controller arguments #300

Closed shreyas-badiger closed 3 years ago

shreyas-badiger commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #300 (2395d2d) into controller-v2 (15007b3) will decrease coverage by 0.12%. The diff coverage is 25.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           controller-v2     #300      +/-   ##
=================================================
- Coverage          36.80%   36.67%   -0.13%     
=================================================
  Files                  7        7              
  Lines                663      668       +5     
=================================================
+ Hits                 244      245       +1     
- Misses               401      405       +4     
  Partials              18       18
Flag Coverage Δ
unittests 36.67% <25.00%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/common/utils.go 0.00% <0.00%> (ø)
controllers/rollingupgrade_controller.go 0.00% <ø> (ø)
controllers/upgrade.go 40.41% <40.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15007b3...2395d2d. Read the comment docs.