search

keikoproj / upgrade-manager

Reliable, extensible rolling-upgrades of Autoscaling groups in Kubernetes
Apache License 2.0
140 stars 45 forks source link

Golang lint fix: remove import duplicates #318

Closed figo closed 2 years ago

figo commented 2 years ago

using tool https://staticcheck.io/

codecov[bot] commented 2 years ago

Codecov Report

Merging #318 (35b5fd0) into master (eaea1ab) will not change coverage. The diff coverage is 75.00%.

:exclamation: Current head 35b5fd0 differs from pull request most recent head 716dcab. Consider uploading reports for the commit 716dcab to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files          12       12           
  Lines        1160     1160           
=======================================
  Hits          806      806           
  Misses        313      313           
  Partials       41       41
Flag Coverage Δ
unittests 69.48% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/rollingupgrade_controller.go 70.00% <75.00%> (ø)
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaea1ab...716dcab. Read the comment docs.

eytan-avisror commented 2 years ago

@figo We don't merge into master any more, this is actually deprecated code, latest code we use is in controller-v2 branch, we should merge it into master but @shreyas-badiger has been having some issues with that.

figo commented 2 years ago

@figo We don't merge into master any more, this is actually deprecated code, latest code we use is in controller-v2 branch, we should merge it into master but @shreyas-badiger has been having some issues with that.

Thanks @eytan-avisror, will close this one. hopefully master branch can be up to date soon.