Deployment manifest removed / readme needs updating

preflightsiren commented 2 years ago

Is this a BUG REPORT or FEATURE REQUEST?: Bug report

What happened: https://raw.githubusercontent.com/keikoproj/upgrade-manager/master/deploy/rolling-upgrade-controller-deploy.yaml was deleted as part of https://github.com/keikoproj/upgrade-manager/commit/167e10b590bd6cb71c513badd2283b7319e7d369 and a replacement manifest has not been provided, nor the readme has been updated with new deployment instructions.

What you expected to happen: Either a replacement exists, or new instructions on how to deploy the controller provided.

How to reproduce it (as minimally and precisely as possible): n/a

Anything else we need to know?: n/a

preflightsiren commented 2 years ago

found that kustomize build https://github.com/keikoproj/upgrade-manager.git/config/default\?ref\=v1.0.2 might be the best way to support creating these manifests.

shreyas-badiger commented 2 years ago

@preflightsiren Did you try doing a make manifests followed by a make install?

preflightsiren commented 2 years ago

@shreyas-badiger this isn't being run from within the codebase. I have a repo that contains all my clusters configuration, part of that repo we have vendored manifests eg.

      - rm -rf {{.VENDORDIR}}; mkdir -p {{.VENDORDIR}}
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instancemgr.keikoproj.io_instancegroups.yaml -O {{.VENDORDIR}}/crd.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instance-manager-deployment.yaml -O {{.VENDORDIR}}/deployment.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/rbac/role.yaml -O {{.VENDORDIR}}/role.yaml

for upgrade-manager I have:

      - rm -rf {{.VENDORDIR}}; mkdir -p {{.VENDORDIR}}
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instancemgr.keikoproj.io_instancegroups.yaml -O {{.VENDORDIR}}/crd.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instance-manager-deployment.yaml -O {{.VENDORDIR}}/deployment.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/rbac/role.yaml -O {{.VENDORDIR}}/role.yaml

I don't imagine most larger deployments will want to manually apply configuration, especially without additional customisation.

keikoproj / upgrade-manager

Deployment manifest removed / readme needs updating #336