search

keikoproj / upgrade-manager

Reliable, extensible rolling-upgrades of Autoscaling groups in Kubernetes
Apache License 2.0
140 stars 45 forks source link

fix: modified UniformAcrossAzUpdateStrategy update strategy to be as expected #395

Closed ccpeng closed 10 months ago

ccpeng commented 10 months ago

fixes: https://github.com/keikoproj/upgrade-manager/issues/349

the README has a broken link to uniform_across_az_update_strategy.yaml but I think this is the intended behavior

codecov[bot] commented 10 months ago

Codecov Report

Merging #395 (70a18e2) into master (84dd4a7) will not change coverage. The diff coverage is 70.58%.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   39.09%   39.09%           
=======================================
  Files           7        7           
  Lines         931      931           
=======================================
  Hits          364      364           
  Misses        540      540           
  Partials       27       27
Flag Coverage Δ
unittests 39.09% <70.58%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/upgrade.go 46.21% <70.58%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ZihanJiang96 commented 10 months ago

LGTM