codecov[bot]
commented
8 months ago Codecov Report
Attention: Patch coverage is 82.97872% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 47.98%. Comparing base (
7511a22) to head (6598147).
| Files | Patch % | Lines |
|---|---|---|
| controllers/upgrade.go | 82.97% | 7 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #438 +/- ## ========================================== + Coverage 43.75% 47.98% +4.23% ========================================== Files 7 7 Lines 1104 1119 +15 ========================================== + Hits 483 537 +54 + Misses 575 540 -35 + Partials 46 42 -4 ``` | [Flag](https://app.codecov.io/gh/keikoproj/upgrade-manager/pull/438/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keikoproj) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/keikoproj/upgrade-manager/pull/438/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keikoproj) | `47.98% <82.97%> (+4.23%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keikoproj#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently, UniformAcrossAZ update strategy doesn't consider the in-progress instances. Because of this, we might end up cordoning more number of instances than the
rollup.maxUnavailable.