search

keimpema / Usenet

A library for working with Usenet. It offers an NNTP client, an NZB file parser, builder, writer, a yEnc encoder and decoder.
MIT License
45 stars 14 forks source link

Copied code without license notice #7

Closed khellang closed 5 years ago

khellang commented 5 years ago

It seems you've taken quite a bit of inspiration and/or copied substantial bits of code from the following of my repositories, without adding proper attribution as required by the MIT license;

You even opened a pull request at https://github.com/khellang/yEnc/pull/1, right before this repo was created. I suggest you include proper attribution.

leastprivilege commented 5 years ago

..and I would suggest this attribution happens in both the source files, as well as the readme.

FransBouma commented 5 years ago

File a DMCA takedown with GitHub. License violations shouldn't be tolerated. Harmen, je weet wel beter, toch? OF de license nakomen, OF de repo weghalen.

keimpema commented 5 years ago

Kristian, your are totally right and I am sorry. It is true that I initially wanted to use all the libraries you mentioned and created. I also wanted to contribute with the PR you mentioned. I guess I got caried away and let my enthousiasm get the best of me and I was too impatient to wait for your response. I was really inspired by your code and although most of mine is build from scratch there is indeed a fair amount in there that is (based on) yours.

I will add attribution as mentioned in the readme and source files. Will this be sufficient? If not I totally understand and I will take down this repo.

khellang commented 5 years ago

I will add attribution as mentioned in the readme and source files. Will this be sufficient?

No worries! I would appreciate that. Thanks for understanding 👍