search

keiosweb / moneyright

Arbitrary precision arithmetic-based Money value object following GAAP rounding principles
MIT License
20 stars 4 forks source link

Currencies not built #5

Closed bendavies closed 9 years ago

bendavies commented 9 years ago

Hey,

It looks like https://github.com/keiosweb/moneyright/blob/master/composer.json#L41 is not called when including this library as a vendor, so the currencies aren't built.

Maybe something is missing from the docs? Like adding "php vendor/keios/moneyright/make_currencies.php" to your own composer post-install/update-cmd scripts?

or maybe currencies.php should be committed in the library?

Cheers, Ben

lbialy commented 9 years ago

Thanks for your input, this is true - composer does not call scripts of dependencies (https://github.com/composer/composer/issues/1193), so I think I will just commit currencies.php into library (no real reason to force everybody to use post-install-cmd / post-update-cmd in their top composer.jsons - we'll just have to remember to regenerate on each release).

lbialy commented 9 years ago

Closed with 1.0.6 release.