search

keiranking / Phil

A crossword maker.
http://www.keiranking.com/phil
Apache License 2.0
282 stars 85 forks source link

Fixed numbering issues #19

Open joetime opened 5 years ago

joetime commented 5 years ago

I went ahead and fixed this issue. See before and after below. In BEFORE the across numbers 11, 12, 13, 14, 17, etc. are incorrect.

I also added an option for 'allow two letter words' that can be utilized in the future.

Note this also fixes/removes the total number of clues listed in the printout (i.e. it removes the unused ones).

Thanks for this amazing application! I have a few more ideas I'd like to implement, so hopefully you appreciate the help.

BEFORE:

screen shot 2018-09-27 at 8 31 06 am

AFTER: screen shot 2018-09-27 at 8 30 48 am

maxmetcalfe commented 4 years ago

Thanks for fixing this issue! I was able to apply your patch and create a sweet puzzle 😁

I noticed an issue where two letter words were not being assigned a number. In checkIsAcross() and checkIsDown(), I think you should reference xw.allowTwoLetterWords and not the global allowTwoLetterWords.