keiranking / Phil

A crossword maker.
http://www.keiranking.com/phil
Apache License 2.0
282 stars 85 forks source link

Across and down blocks of length one no longer treated as across or down clues. #43

Open impregnablequestion opened 12 months ago

impregnablequestion commented 12 months ago

Modified the cross.js file slightly so that I could use Phil Crossword to write cryptic style crosswords without down clues and labels being generated for each square in a single across clue, and vice versa.

Achieved this by updating the IsAcross and IsDown conditions in the UpdateLabelsAndClues function in cross.js (line 535) to loop to the second last index in each row and column (the last index will never be a valid clue) and adding a check for the following square in the row not being filled black. Have tested it extensively and no other functionality in the app is broken by this change.

Before:

Screenshot 2023-07-09 at 13 37 07

For the purposes of creating an english-style cryptic grid I couldn't use Phil Crossword, as it generated invalid labels and clues

After:

Screenshot 2023-07-10 at 18 13 30

Phil Crossword now works for my purposes, and doesn't generate labels or clues that have a length of one