search

keirf / amiga-stuff

The Unlicense
257 stars 26 forks source link

[LOW priority] Zip file has commit ID instead of version number when building with Docker #49

Closed rjnorthrow closed 3 years ago

rjnorthrow commented 3 years ago

When building with Docker, since v-1.17, the zip output file has the Git commit ID instead of the version number and it's the same when specifying -e COMMIT=testkit-v1.18:

docker run -ti --rm -v$(pwd):/output rjnorthrow/atk:latest

Expected output: AmigaTestKit-v1.18.zip, actual output: AmigaTestKit-803ec6a.zip

Up to v1.16, the zip file was named as expected

keirf commented 3 years ago

You need to update the command line to pass VER=v1.18 (or whatever) to make.

The default actually is to use a commit hash for the version on all builds to show that they are non-release. You might consider therefore that the current Docker behaviour is actually correct: Since official release binaries are not being generated.

rjnorthrow commented 3 years ago

Thank you :-)