keirf / disk-utilities

The Unlicense
231 stars 50 forks source link

Compilation error in amiga cobra and pick_n_pile #185

Closed bmwslangen closed 1 year ago

bmwslangen commented 1 year ago

Ran into two compilation issues (which probably only appear in some specific setups/configurations). My setup is Cygwin with GNU make and C compiler (on Windows 7).

It complains that u_int16_t and u_int8_t is undefined at two places:

libdisk/format/amiga/cobra.c:64 if ((uint16_t)s->word != 0x4489)

libdisk/format/amiga/pick_n_pile.c:69 sec = (uint8_t)(be32toh(dat[0]) >> 16)/4;

The fix is probably that these should be uint16_t and uint8_t instead. Seems like this was also the fix for issue #150

Tried out the changes locally and then the compilation went through successfully without any issues.