keirf / flashfloppy-osd

On Screen Display and keyboard controller for FlashFloppy
The Unlicense
57 stars 15 forks source link

Kickstart ROM switching support #8

Closed penfold42 closed 4 years ago

penfold42 commented 4 years ago

F1..F4 select kickstart roms with PB8, PB9 OSD config for

keirf commented 4 years ago

Do you know how to "git rebase -i"? Let's get keirf:pins agreed and into master, and then it would be preferable if you could rebase and squash these commits on top.

penfold42 commented 4 years ago

Ok, I think I know enough git to be dangerous - stack overflow for the pin.

Check out https://github.com/penfold42/FF_OSD/tree/kick_on_pins

keirf commented 4 years ago

Ok I'm going to refactor this one, to create a generic concept of hotkeys and their actions on pins in GPIOB. I will make them display an OSD notification when hotkeys are pressed. And I will include an optional config which implements the hotkey actions in your patch.

The downside will be no run-time configurability. Yet. As you say we can assume full keyboard so I think we'll make this configurable via keyboard and perhaps serial, on a second config menu.

penfold42 commented 4 years ago

Cool.

While you’re hacking at the keyboard code:

keirf commented 4 years ago

Okay this is done and in master. See what you think: The config is in default_config.c.

keirf commented 4 years ago

'Help' exits config menu: It could, it's a bit of a pain to implement, and what do you do with the half changed config?

'Delete' forces I2C OSD off, presumably? And forever until 'Delete' pressed again?

keirf commented 4 years ago

'Delete' -> OSD On/Off is now in master. It's also tempting to put this on a push button at say PB5.

penfold42 commented 4 years ago

Excellent !

On the help front - use or discard would be ok.

For me, it’s mostly usefully on the banner screen - oops, get me out of here.

keirf commented 4 years ago

You can bash through with Up Arrow a few times and get outta there... But I will look to implement your suggestioon.