Closed penfold42 closed 4 years ago
Do you know how to "git rebase -i"? Let's get keirf:pins agreed and into master, and then it would be preferable if you could rebase and squash these commits on top.
Ok, I think I know enough git to be dangerous - stack overflow for the pin.
Check out https://github.com/penfold42/FF_OSD/tree/kick_on_pins
Ok I'm going to refactor this one, to create a generic concept of hotkeys and their actions on pins in GPIOB. I will make them display an OSD notification when hotkeys are pressed. And I will include an optional config which implements the hotkey actions in your patch.
The downside will be no run-time configurability. Yet. As you say we can assume full keyboard so I think we'll make this configurable via keyboard and perhaps serial, on a second config menu.
Cool.
While you’re hacking at the keyboard code:
Okay this is done and in master. See what you think: The config is in default_config.c.
'Help' exits config menu: It could, it's a bit of a pain to implement, and what do you do with the half changed config?
'Delete' forces I2C OSD off, presumably? And forever until 'Delete' pressed again?
'Delete' -> OSD On/Off is now in master. It's also tempting to put this on a push button at say PB5.
Excellent !
On the help front - use or discard would be ok.
For me, it’s mostly usefully on the banner screen - oops, get me out of here.
You can bash through with Up Arrow a few times and get outta there... But I will look to implement your suggestioon.
F1..F4 select kickstart roms with PB8, PB9 OSD config for