search

keirf / greaseweazle

Tools for accessing a floppy drive at the raw flux level
The Unlicense
987 stars 99 forks source link

Issue with latest bitarray releases (>3.0.0) #502

Closed sdsnatcher73 closed 3 weeks ago

sdsnatcher73 commented 3 weeks ago

On my MacBook with python 3.13 installed through brew I recently started running into issues when GreaseWeazle tries to read or verify written data:

Format pc98.2hd Writing c=0-76:h=0-1 T0.0: Writing Track (Flux: 166.7ms period, 183.3 ms total, Terminate at index) FATAL ERROR: 'bitarray.bitarray' object has no attribute 'itersearch'**

Going back to earlier GW releases did not fix it while those worked before.

Okay seems itersearch and iterdecode were removed in 3.0 of the bitarray, check the changelog. The search and decode functions now return an iterator. I guess GW could require version 2.9.3 of bitarray in some way and a future 1.21 could switch to 3.0?

keirf commented 3 weeks ago

Either I need to require >=3 and fix the code, or I need to require <3. I guess the latter is simpler for now. Let me see.

keirf commented 3 weeks ago

Should be fixed in release tags v1.21 and latest.