search

keis / base58

Base58 and Base58Check implementation compatible with what is used by the bitcoin network.
MIT License
180 stars 59 forks source link

Include tests in PyPI tarball #31

Closed dotlambda closed 6 years ago

dotlambda commented 6 years ago

This e.g. allows downstream distributions to use your test suite as integration tests.

Fixes #32

keis commented 6 years ago

Hey,

Could you help me understand what the specific use you have this? In general this not a very common practice and including it in the manifest like this don't mean it will get installed with pip so you wouldn't really see this file anyway. That may be a good thing though as this is packaged as a plain module and the tests would be another top-level module which is kinda silly.

nyanloutre commented 6 years ago

My specific use case is for packaging into NixOS. For now I used the GitHub URL, but a PyPI URL would be more stable as it doesn't include a username.

keis commented 6 years ago

hmm ok, makes sense

keis commented 6 years ago

Thanks for the PR, new tarball with tests included published as version 1.0.1

nyanloutre commented 6 years ago

Thanks !