Distribute type data (PEP 561)

keis / base58

Base58 and Base58Check implementation compatible with what is used by the bitcoin network.

MIT License

180 stars 59 forks source link

Distribute type data (PEP 561) #47

Closed hukkin closed 4 years ago

hukkin commented 4 years ago

Note that I had to place base58.py in a package. Quoting https://www.python.org/dev/peps/pep-0561/ :

This PEP does not support distributing typing information as part of module-only distributions.

keis commented 4 years ago

LGTM! Does anything need to change in the way this is packaged to include the type information or would that all be handled be setuptools?

hukkin commented 4 years ago

All should be handled by setuptools. So a just a regular python3 setup.py sdist && twine upload dist/* for instance should successfully push a build with type data to PyPI.

keis commented 4 years ago

Great! I'll probably look into cutting a 2.0.0 then :tada: