keis / base58

Base58 and Base58Check implementation compatible with what is used by the bitcoin network.
MIT License
180 stars 59 forks source link

base-45 standards #65

Closed sg495 closed 2 years ago

sg495 commented 3 years ago

Not quite an issue, given that the library does not advertise base-45 functionality, but perhaps something to keep in mind. The proposed base-45 encodings I'm aware of (main two listed below) are different from the BTC base-58 encoding:

keis commented 3 years ago

Hey, thanks for the notice.

This does indeed look to be a more traditional base64 style where you can consider some octets in isolation and not the bitcoin base58 style that requires repeated division of the entire payload. This library supports arbitrary bases but it's not a design goal to be compatible with any standard for those and you will still get the "bitcoin style" encodings.

keis commented 3 years ago

@tanupoo maybe you have some insight into the details of the base45 alphabet that was added?