keisen / tf-keras-vis

Neural network visualization toolkit for tf.keras
https://keisen.github.io/tf-keras-vis-docs/
MIT License
311 stars 45 forks source link

Python 3.8 support #9

Closed bersbersbers closed 4 years ago

bersbersbers commented 4 years ago
user@host:~/pip_patches> python --version
Python 3.8.2
user@host:~/pip_patches> pip install tf-keras-vis==0.2.2
ERROR: Could not find a version that satisfies the requirement tf-keras-vis==0.2.2 (from versions: 0.0.1, 0.1.0)
ERROR: No matching distribution found for tf-keras-vis==0.2.2
keisen commented 4 years ago

Thank you for your reporting. I'll deal with this issue when TF supported Python 3.8+.

https://www.tensorflow.org/install#install-tensorflow-2

bersbersbers commented 4 years ago

Which is now :)

Windows/Linux binaries for py3.8 are available

https://github.com/tensorflow/tensorflow/releases/tag/v2.2.0-rc3

Also, https://pypi.org/project/tensorflow/2.2.0rc4/#files and https://github.com/tensorflow/tensorflow/issues/33374#issuecomment-625053336

keisen commented 4 years ago

Thank you for letting me know! I'll deal with it in PR/#7.

bersbersbers commented 4 years ago
> pip install tf-keras-vis==0.2.4
ERROR: Could not find a version that satisfies the requirement tf-keras-vis==0.2.4 (from versions: 0.0.1, 0.1.0)
ERROR: No matching distribution found for tf-keras-vis==0.2.4

PyPI says Requires: Python >=3.5, <=3.8 - could it be that that excludes Python 3.8.2?

keisen commented 4 years ago

Thank you for letting me know that! I didn't realize it. For now, I applied a patch to setup.py and uploaded v0.2.5 to PyPI. Could you please try it again.

bersbersbers commented 4 years ago

Successfully installed tf-keras-vis-0.2.5

Beautiful, thank you!