search

keith-b-git / ct

Club Triumph
GNU General Public License v3.0
1 stars 0 forks source link

[Forum] Other users' Threads view is empty. #5

Open meredevelopment opened 5 years ago

meredevelopment commented 5 years ago

Expected Behaviour

When viewing another user's threads, via the sidebar 'discussions' link or directly, to be shown the users threads.

Actual Behaviour

The View loads, but no actual threads are shown.

Steps to Reproduce the Problem

  1. View a user's profile page. i.e. https://club.triumph.org.uk/menu/799/user/profile (Tim Hunt's).
  2. Click on the Discussion box/link: image
  3. See the resulting empty list: image

Notes

Thread view does work as expected when viewing my own threads page.

meredevelopment commented 5 years ago

@keith-b-git This seems to be 'fixed' in that there's no longer a listing, because all text in the box links to the latest post (or forum if there's no post, by the look of code).

Is a listing of discussions planned again or will it stay as-is now? If it's staying like this could the 'Discussions' bit be removed completely when viewing 'user_profile'? Otherwise I think it's like 'there are n discussions here, but you can't see them!'

keith-b-git commented 5 years ago

There are a few things that need looking at here. The main problem is a permissions one -

update menu set view_messages = 128 where type = 'user_profile';

will enable them, need to check that doesn't cause other problems. I'll do some more testing, I'm sure I disabled it for a reason! It uses different queries to the 'normal' pages, as it is actually searching for posts by author rather than threads by tags, so it is actually presenting a list of posts (i.e. threads and replies) in a 'threads' view, which isn't ideal. The behaviour of the discussions link in sidebar needs clarifying, this has changed since the upgrade and now links directly to the latest post, rather than the listing. I'm now unclear as to which is the desired behaviour, what would a typical user expect?