search

keith / buildifier-prebuilt

A bazel toolchain for using prebuilt binaries for buildifier and buildozer
MIT License
35 stars 13 forks source link

add support for -diff_command #33

Closed jmelahman closed 2 years ago

jmelahman commented 2 years ago

It seems it's somewhat common to not have tkdiff installed (https://github.com/bazelbuild/buildtools/issues/39) and indeed I do not which gives me,

$ bazel run //:buildifier.check
INFO: Analyzed target //:buildifier.check (1 packages loaded, 1 target configured).
INFO: Found 1 target...
Target //:buildifier.check up-to-date:
  bazel-bin/buildifier.check.bash
INFO: Elapsed time: 0.047s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Build completed successfully, 1 total action
buildifier: selecting diff program with the BUILDIFIER_DIFF, BUILDIFIER_MULTIDIFF, and DISPLAY environment variables is deprecated, use flags -diff_command and -multi_diff instead
./BUILD:
--: line 1: tkdiff: command not found
exit status 127
keith commented 2 years ago

I created 0.4.1 with this included!