search

keith / buildifier-prebuilt

A bazel toolchain for using prebuilt binaries for buildifier and buildozer
MIT License
35 stars 13 forks source link

Add buildifier_test #40

Closed erikkerber closed 1 year ago

erikkerber commented 2 years ago

The rule here has diverged a bit from buildtools, namely that buildtools wraps the "diff" mode in a test rule useful for CI checks

https://github.com/bazelbuild/buildtools/blob/master/buildifier/buildifier.bzl#L37-L41

I was going to adopt this prebuilt strategy and clean up our WORKSPACE a bit, but hit a snag in that small difference.

Checking here if matching the rules in the buildtools source is a goal, and if so I'll open a patch.

keith commented 2 years ago

Yea I think having similar rules to that repo would be good. I can't recall but I think I omitted that one since it doesn't seem super common to use these days because of the inability to glob files.

keith commented 1 year ago

Included in 5.1.0.1, thanks!