Added missing dependencies and added example with integration test.

keith / buildifier-prebuilt

A bazel toolchain for using prebuilt binaries for buildifier and buildozer

MIT License

35 stars 13 forks source link

Added missing dependencies and added example with integration test. #6

Closed cgrindel closed 2 years ago

cgrindel commented 2 years ago

Related to #5.

Added missing dependency on bazel-skylib.
Added build_test so that bazel test /... works.
Added example/simple to demonstrate use of repository and implement integration tests that ensure it works for Bazel 4.2.2 and 5.0.0.

cgrindel commented 2 years ago

If you are OK with the new tests, I can also add a GitHub Actions workflow to execute the tests.

cgrindel commented 2 years ago

I'll add the GitHub Actions workflow and update this PR.

cgrindel commented 2 years ago

I added the GitHub Actions workflow files. However, I think that you will need to approve the running of workflows, because I do not have permissions.

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

keith commented 2 years ago

Huh I don't see the button yet. I invited you to the repo to simplify

cgrindel commented 2 years ago

Well, the workflow does not seem to want to run. I suspect it is a permissions issue, but I am not sure how to debug it with my current permissions. If you want to give me write access to the repo, I can try to debug it. Otherwise, I would suggest that we go ahead and merge this PR. Let me know what you would like to do.

keith commented 2 years ago

Lets fixup if it fails now that it's merged

keith commented 2 years ago

I did invite you to the repo

cgrindel commented 2 years ago

Sorry. Just saw the invite. Thanks.