Closed MillerJhang closed 1 year ago
Is the solution here to be using the shell snippet that you copy paste from bazel? should be fine to update if so
No solution was provided from me 😅
But if you run the buildifier in the way mentioned as step 8 above, you can see that the line does readlink
fails because the first dir is external
whereas it maybe should be ../ because with the --nolegacy_external_runfiles the
++ readlink external/buildifier_darwin_arm64/file/buildifier
can you add a repro case here? I can't repro this in our project. what version of bazel + buildifier prebuilt are you on
or better yet a PR with a failing test
The version of bazel and buildifier-prebuilt used in the reproduction steps in the start of this thread is 6.3.1 and 6.1.2
I found that it can be fixed on my laptop after changing the first .path
to .short_path
in this line, and it works either specifying nolegacy_external_runfiles
or not.
Should I create a PR of that, or any suggestion?
worth a try with a PR but I think that was just changed to support windows
Thanks for the work on this project! It's so great but I'm encountering an issue blocking me to continue with it.
Issue:
build --nolegacy_external_runfiles
, buildifier-prebuilt still looks forexternal/buildifier_darwin_arm64/file/buildifier
Reproduction:
rules_python
as the examplebuild --nolegacy_external_runfiles
into the file.bazelrc
; I added it in the first line. Then runbazel run //:buildifier.check
agan. or 6-2. Run "bazel run //:buildifier.check --nolegacy_external_runfiles"--run_under="bash -x"
and--sandbox_debug
and run again for more details.Expectation:
build --nolegacy_external_runfiles