Fix: Not compatible with --nolegacy_external_runfiles

keith / buildifier-prebuilt

A bazel toolchain for using prebuilt binaries for buildifier and buildozer

MIT License

35 stars 13 forks source link

Fix: Not compatible with --nolegacy_external_runfiles #77

Closed MillerJhang closed 1 year ago

MillerJhang commented 1 year ago

This PR aims for fixing issue #74.

Tested on M1 Mac 13.4.1 and x86_64 Ubuntu 20.04.6 LTS with buildifier-prebuilt 6.1.2.1 under Bazel 6.3.2, works either with --nolegacy_external_runfiles or not.

keith commented 1 year ago

https://github.com/keith/buildifier-prebuilt/pull/69/files#r1260398463

i think it will fail ci on windows given this comment

MillerJhang commented 1 year ago

Thanks for the comment :)

Now the CI checks are complete and all three tests are passed. Also, from this line in the same commit you mentioned, we can know that the out_ext would be .bash for non-windows platform, so that this PR will not affect Windows users.

keith commented 1 year ago

thanks!