search

keith / git-pile

Stacked diff support for GitHub workflows
MIT License
148 stars 11 forks source link

Chained PR submission #3

Closed keith closed 2 years ago

keith commented 2 years ago

While chained PRs isn't really the goal of git-pile, and it doesn't really help you with merging things, or anything on the GitHub side of things. It mostly just works if you create the PRs with the right bases, and squash and merge. I have a prototype of this here https://github.com/keith/dotfiles/pull/14/ that I should finish up

iainsmith commented 2 years ago

👋 @keith. I was experimenting with this and was wondering if --onto might be a good flag for this, similar to git rebase --onto. I appreciate the flags aren't quite in the same order, but IMO it feels like a natural extension.

git submitpr head --onto head~2

What do you think?

Happy to raise a PR from https://github.com/iainsmith/git-pile/commit/7ff4d6faa89075867093e13215e2533461d55a72 (which is a tweak of https://github.com/keith/dotfiles/pull/14) if you are happy with it.

keith commented 2 years ago

Nice! yea I like the --onto wording, it's much nicer than the --commit arg I had. I think that change looks good if you want to submit a PR! 🎉

keith commented 2 years ago

https://github.com/keith/git-pile/pull/16