keith / investigate.vim

A Vim plugin for looking up documentation
http://keith.github.io/investigate.vim/
MIT License
297 stars 20 forks source link

New way for plugins to call Dash with keywords #4

Closed Kapeli closed 10 years ago

Kapeli commented 10 years ago

Dash 1.9.3 comes with a new way for plugins to call Dash and send over a list of keywords which Dash uses to enable/disable docsets.

This is all described at http://kapeli.com/dash_plugins.

The advantage for using this is that you can send over more than one keyword to Dash and the keywords you specify are matched regardless of what the user's settings are (e.g. if the user modified the keyword for the Rails docset to be just "r", you can still send "rails").

keith commented 10 years ago

That's awesome! Will look to implement this tomorrow thanks

keith commented 10 years ago

I think just this change https://github.com/Keithbsmiley/investigate.vim/commit/c085b3c5d694c9b9435c9f440d86aeab67273af1 will set this up to work correctly since I currently don't support multi-word queries. As you can see I've commented that out for now since that update just came out within the last few days. I'll merge put it into the release soon. Thanks!

Kapeli commented 10 years ago

I can't tell, but are you sending the query= as percent escaped? If you don't percent escape, things will fail if the query contains a & and possibly other chars.

I'm not really sure what you mean by multi-word queries. Do you mean multi-keyword?

keith commented 10 years ago

Hmm yea I forgot about that, I'll have to escape it. Yes right now you can only call the plugin with a single keyword.

keith commented 10 years ago

Will have to do that manually via this table

keith commented 10 years ago

https://github.com/Keithbsmiley/investigate.vim/commit/ff7666a1cfb8abcc9f4b2acc8d48f673880b0e65

Thanks!