search

keithamus / LinkyPass

LinkyPass Google Chrome Extension
http://github.com/keithamus/LinkyPass
MIT License
36 stars 15 forks source link

Ctrl+Shift+P shortcut collides with Print dialog on Chrome Dev Channel #9

Closed rossng closed 10 years ago

rossng commented 13 years ago

In the current dev-channel version of Chrome (15.0.865.1000 dev-m), the default CTRL+SHIFT+P shortcut now opens the print dialog.

keithamus commented 13 years ago

I may change this to CMD/CTRL + Shift + 8 (i.e CMD/CTRL *) - if anyone objects, let it be known.

wormeyman commented 12 years ago

I use the letter S as it is on the home row and doesn't conflict with anything

keithamus commented 12 years ago

Not massively in love with the idea as Ctrl/Cmd+Shift+S is usually "save-as", not sure how my muscle memory would contend with that.

Maybe I should just make it configurable?

wormeyman commented 12 years ago

Yeah keep it configurable like it is now.

Sent from my phone, please excuse any strange autocorrects or misspellings.

On May 30, 2012, at 12:33 PM, Keith Cirkelreply@reply.github.com wrote:

Not massively in love with the idea as Ctrl/Cmd+Shift+S is usually "save-as", not sure how my muscle memory would contend with that.

Maybe I should just make it configurable?

Reply to this email directly or view it on GitHub: https://github.com/keithamus/SuperChromePass/issues/9#issuecomment-6019129

rossng commented 12 years ago

fwiw, I've been using Ctrl+Shift+E since creating this bug and haven't noticed any problems. It doesn't seem to conflict with anything plus it's a one-handed shortcut.

Obviously keep it configurable, but this might be an idea for a default.

keithamus commented 12 years ago

Shows how long it has been since I worked on it! Didn't even remember that the shortcut is configurable.

wormeyman commented 12 years ago

Ctrl+Shift+E is a good idea as it will avoid conflicts, i would go with that then you can close this bug easily since it is re-configurable.

keithamus commented 10 years ago

Hey @rossng and @wormeyman, this is fixed in the new 2.0.0 version of SuperChromePass (now called LinkyPass) which is available in the Chrome store now. The new version uses Chrome's native shortcuts, meaning you can freely change it to whatever you want, but by default it uses Ctrl/Cmd+shift+8, as I thought it made the most sense as a shortcut (shift+8 being an *).

I'd love to get your guys opinions on the new version. It's pretty much a complete rebuild, so please, check it out!