search

keithamus / jwerty

⌨ Awesome handling of keyboard events
http://keithamus.github.io/jwerty
Other
1.21k stars 109 forks source link

IE 8 issue when binding to enter key in textboxes #49

Open osudude opened 10 years ago

osudude commented 10 years ago

We use jwerty for handling enter key in textboxes. Works great in all browsers except for IE 8. When using jwerty to handle enter key in IE8 texbox, the default behavior is not prevented and causes an undesired form post to happen.

This is correctable in v.3 via the following jwerty.js code:

is: function (jwertyCode, event, i /? 0/) { jwertyCode = new JwertyCode(jwertyCode); // Default i to 0 i = i || 0; // We are only interesting in i of jwertyCode; jwertyCode = jwertyCode[i]; // jQuery stores the real event in originalEvent, which we use // because it does annoything stuff to metaKey event = event.originalEvent || event;

        //!!!!!!!!!Modification for IE 8 support!!!!!!!!!  Thanks be to ninja master Teddy for finding this!!!
        event.metaKey = event.metaKey || false;
keithamus commented 10 years ago

Odd fix, but thanks for finding it. Fancy turning this into a pull request (without the comment also)? That way you'll get proper credit for it and will be featured on our contributors page!

osudude commented 10 years ago

Apparently, this issue only happens when using JWERTY with Jquery 1.9 and above in IE8.