search

keithamus / jwerty

⌨ Awesome handling of keyboard events
http://keithamus.github.io/jwerty
Other
1.21k stars 107 forks source link

added unbinding. jwerty.key now returns an unsubscription handle #54

Closed makoConstruct closed 10 years ago

makoConstruct commented 10 years ago

Fixes #19

keithamus commented 10 years ago

Thanks so much for the PR @makoConstruct! Looking good, but two things are missing for me to merge this: tests and documentation.

You've done a good job at commenting the code, but I'd like you to also edit the README.md and just mention this feature.

Also, if you could add some tests that'd be amazing. Have a look at the test.js file to familiarise yourself with the tests.

If you need any help with these, or would rather not do them - just let me know.

keithamus commented 10 years ago

:+1: You're now in the jwerty hall of fame :wink: