search

keithamus / sort-package-json

Sort an Object or package.json based on the well-known package.json keys
MIT License
806 stars 87 forks source link

feat: add support for `prettierIgnore` #266

Closed mataha closed 6 months ago

mataha commented 2 years ago

The goal of this PR is to add support for prettierIgnore - an alternative to defining ignored paths in Prettier in a separate .prettierignore file, consisting of an array of file blobs that should not be sorted. The key behaves exactly the same as eslintIgnore does (with the exception of, well... handling ignores for Prettier instead of for ESLint).

The PR in Prettier hasn't been merged yet, though I imagine it will be in the nearest future.

See: prettier/prettier#12672

fisker commented 2 years ago

As a maintainer of both this repo and Prettier, I have to say that Prettier PR is far from ready.

mataha commented 2 years ago

As a maintainer of both this repo and Prettier, I have to say that Prettier PR is far from ready.

Probably not the best place to have this conversation, but: what is it lacking, then?

fisker commented 2 years ago

I'll review in Prettier now.