search

keithamus / tempus

Tempus - Time for a new Date()
http://tempus-js.com
Other
94 stars 9 forks source link

Fix for in loops #10

Closed llafuente closed 12 years ago

llafuente commented 12 years ago

Reproduce the problem: <script src="mootools.js" /> <!--later --> <script src="tempus.js" />

You will get an error in the console (substr is not a valid function)

That's because mootools modify the Array.prototype exposing functions to for in loops.

here the fix :)

-- edit, forget to escape the HTML

llafuente commented 12 years ago

Hi there.

Please merge the pull, I fixed another bug and I dont know how to send the new pull request (i will try tomorrow again)

The new one is a internet explorer issue with the constructor.

keithamus commented 12 years ago

Hi, firstly thanks very much for the two fixes!

The best way to issue a pull request is clone the master branch, then create a new branch with the name of the fix and add commits to only that branch, that way your branch will only contain commits for that particular fix, avoiding the problem you have now.

I have some small points on your first fix (which I'm totally happy to merge if these are fixed)