search

keithb418 / scrum-team-app

Apache License 2.0
3 stars 5 forks source link

made a complete full coverage on unit test and fixed small bugs fo… #109

Open Crunchwrap78 opened 6 years ago

Crunchwrap78 commented 6 years ago

Unit tests are complete. I have done a full coverage on the actions, components, and reducers. Will leave notes in PR

asc2683 commented 6 years ago

In the future pull requests, would it possible to break it down into smaller chunks of code that correspond to specific functionality and task. So, bug fix which touches the source code should be a separate branch with a detailed commit message. Unit tests preferably should be broken down with a separate branch for the components you're testing. Overall, I like the unit test looks good.

For example, the branching would be:

fix/some-description-of-fix test/unit-test-for-some-component test/unit-test-for-some-other-component