search

keithclark / ZzFXM

A super small music generator for use in size-limited JavaScript productions
https://keithclark.github.io/ZzFXM/
MIT License
418 stars 33 forks source link

Piano - Keyboard keys are strange #20

Closed caesarsol closed 3 years ago

caesarsol commented 3 years ago

Hi, first of all: awesome project!!

I am just fiddling with the Tracker and I notice the keyboard keys associated to the piano keys are strange: the 5 in QWE5TYUIOP part seems out of place. I understand that the Z is the C1, , is the C2, Q is an F2, but then T is a C3 and R should be a semitone under it to make a B3 :)

Anyway, I was just curious about it and wanted to know if you made it on purpose, maybe to let the user easily transition to the fourth?

keithclark commented 3 years ago

Thanks for reporting this.

It's a bug. The keyboard map is incorrect and you're the first person to notice 😄.

The entry for 4 is missing so R onward are rendered in the wrong place.

keithclark commented 3 years ago

Fixed in https://github.com/keithclark/ZzFXM/pull/21/commits/f5923ca7885c1b547b059473559ab01c3023d012. This will be in the next release.

caesarsol commented 3 years ago

Awesome! Yeah I'm told to be picky on details :)