keithclark / ZzFXM

A super small music generator for use in size-limited JavaScript productions
https://keithclark.github.io/ZzFXM/
MIT License
418 stars 33 forks source link

Fix / as shortcut key in Firefox, prevent arrow shortcuts from triggering browser behaviors #40

Open kirbysayshi opened 1 year ago

kirbysayshi commented 1 year ago

/ in firefox is a Find in Page shortcut, which revoked focus from the page. And at least for me, Arrows + cmd + shift was triggering scroll behaviors in a Tree Tab extension I run (tabs as a list to the side). Since that and other behaviors are hard to predict, I think it's best to always preventDefault() once it's clear that a known shortcut is going to be triggered.

This should also fix #37 ! This behavior was one of the first I encountered upon playing around with the app 😢

Thanks for making a cool Tracker app! I plan to use it for some JS13k experiments 😎