sequencer and renderer fixes

keithclark / ZzFXM

A super small music generator for use in size-limited JavaScript productions

https://keithclark.github.io/ZzFXM/

MIT License

418 stars 33 forks source link

sequencer and renderer fixes #9

Closed KilledByAPixel closed 3 years ago

KilledByAPixel commented 3 years ago

Added a sequencer! Bare bones but fully functional. Could use more editing features for better flow.

Also a few improvements to the music function, the format is the same.

fix popping if first notes are empty due to undefined values
allow negative values to stop notes (currently only used for -1)
fix pop at end of song where final note is cut off to allow for better looping

keithclark commented 3 years ago

Thanks for this Frank. Could you move sequencer.html into a folder in the tools directory? It would be good if there was a README and screen grab too — I can add those if you prefer?

KilledByAPixel commented 3 years ago

Looks good! Not sure if need to something else to merge in your changes before you pull.

keithclark commented 3 years ago

Thanks Frank. I'll rebuild the minified version, update readme and merge the changes.

keithclark commented 3 years ago

This PR has been rolled into #11.