search

keithclark / gadebugger

A Chrome, Firefox & Opera devtools extension for debugging Google Analytics tracking code
https://keithclark.github.io/gadebugger/
MIT License
238 stars 65 forks source link

Firefox devtools path fixes #30

Closed keithclark closed 8 years ago

keithclark commented 8 years ago

In Firefox 44 the paths to internal devtools assets changed. GA Debugger uses several devtools modules and stylesheets to ensure the UI looks and behaves identically to the other built-in tools.

This fix introduces a set of helpers for mapping the new asset urls (defined in FF44) to the old format, allowing GA debugger to work in all current versions of Firefox.

Unfortunately, the theme-switching.js file in tool.xul could not be loaded dynamically using a helper so both the new and old urls have been included with <script> elements. Firefox will try and load both these assets even though only one can ever exist — triggering a browser console warning.

Once pre-44 versions of Firefox have phased out the helpers should be removed and extension install.rdf updated to set FF44 as a minimum requirement.

This fix bumps GA Debugger to 2.1.1, but only Firefox users will get this version.

This PR fixes issue #28

keithclark commented 8 years ago

Uploaded to AMO. Waiting for review prior to merge.