search

keithclark / selectivizr

selectivizr is a JavaScript utility that emulates CSS3 pseudo-classes and attribute selectors in Internet Explorer 6-8.
1.71k stars 247 forks source link

explore other (non-doc.write) dom ready solutions #3

Closed paulirish closed 13 years ago

paulirish commented 13 years ago

this old dean edwards snippet was used in jquery but was removed due to edge case incompatibilities.

the doScroll basic check from diego perini (called IEContentLoaded) is much safer.

keithclark commented 13 years ago

I agree, document.write isn't the best way to watch for DOM ready events.

Originally, I used Diego's doScroll() trick but it failed if selectivizr was used in any content loaded into an iframe, so I had to revert back to Dean Edwards technique as it was causing issues for some users.

I'm open to suggestions.

paulirish commented 13 years ago

Ah interesting. I'll tweak the issue title.

ZeeAgency commented 13 years ago

https://github.com/keithclark/selectivizr/pull/6

keithclark commented 13 years ago

Diego has been in touch.

I have a new version of his DOMContentLoaded script to test :)

keithclark commented 13 years ago

Closing this issue as it's become a dupe of issue #4