search

keithclark / selectivizr

selectivizr is a JavaScript utility that emulates CSS3 pseudo-classes and attribute selectors in Internet Explorer 6-8.
1.71k stars 247 forks source link

Fix JSHint Errors #61

Closed jgable closed 3 years ago

jgable commented 11 years ago

Great work on this library, we use it for our app.

We've included some small changes based on JSHint which we use in our build process. Not sure you'll care, but if so, here is a PR for it.

The most controversial thing would be the way I handled the switch -> case fall throughs you had for focus/hover and enabled/disabled. Personally, I don't have a problem with the way you did them, but JSHint does not have a way to turn that error off.

The rest should be little things like unnecessary semicolons and whitespace mixing. There are a couple missing semicolons and bad unescaped regex characters.

corysimmons commented 8 years ago

@keithclark disappeared so I'm going to try and maintain this project at https://github.com/corysimmons/selectivizr2

Would you please reopen/rebase your PR over there?