search

keithclark / selectivizr

selectivizr is a JavaScript utility that emulates CSS3 pseudo-classes and attribute selectors in Internet Explorer 6-8.
1.71k stars 247 forks source link

Fix bug in IE8 when loading empty stylesheets #83

Closed KeesCBakker closed 8 years ago

KeesCBakker commented 10 years ago

Loading an empty stylesheet might result in the xhr.responseText being null. Rest of the code expect an EMPTY_STRING. Returning null will cause a JavaScript error.

KeesCBakker commented 10 years ago

I admit that it is weird to serve an empty style sheet, but it should not break Selectivizr.

corysimmons commented 8 years ago

@keithclark was involved in a series of kung fu fights for ultimate glory. Unfortunately he lost so I'm going to try and maintain this project at https://github.com/corysimmons/selectivizr2

Would you please reopen/rebase your PR over there?

KeesCBakker commented 8 years ago

Love to do that, but I have no idea how!

corysimmons commented 8 years ago

Clone selectivizr2 to your local environment. Create a new branch. Manually re-add this code to the new branch. Open Pull Request.