search

keithdadkins / drone-deploy

Builds, provisions, and deploys DroneCI on AWS.
MIT License
2 stars 0 forks source link

drone-server activating repos in GitHub sets to http instead of https #1

Open keithdadkins opened 5 years ago

keithdadkins commented 5 years ago

Description

Once drone server is up and running and you have activated a repo, builds will fail until you go into the github.com project -> click on settings -> click on webhooks -> edit -> and then update the 'payload' url to use https:// instead of http://.

I'm not sure if this is an upstream GitHub issue, an issue with drone, or something else. It's not a show-stopper, just an unnecessary step.

Screenshots

image

To Reproduce

  1. Activate a GitHub repo in drone ui (https://drone.yourdomain.com)
  2. Push to trigger a build (build)
  3. Go to repo's settings and change web hook url to use https instead of http
  4. Push to trigger a build (passes)
keithdadkins commented 5 years ago

This could be happening because we are using a proxy (http://docs.tea-ci.org/setup/proxy_reverse/#caddy:baa01b1708de72451d6b303294ce3cc6) or possibly because the 'DRONE_HOST' variable.