search

keithgodfrey55 / capstone-project

1 stars 0 forks source link

feedback #2

Open jonathan-chin opened 3 years ago

jonathan-chin commented 3 years ago

overall, this looks good. with your current design, you can:

  1. do validation on search by # so it only allows numbers
  2. use Material UI's autocomplete form search by name
    https://material-ui.com/components/autocomplete/
  3. use Material UI's chips for pokemon types
    https://material-ui.com/components/chips/

to make this more interesting, I would suggest:

allow the user to pick 2 pokemon and based on stats / types, calculate winning probabilities if the two battle.

if you get this done, you can extend it to selecting a whole team vs another whole team (with the option to select pokemon at random) and calculate winning odds among two teams.

I think it's achievable within the time you have left.

jonathan-chin commented 3 years ago

to add to this, consider how you can implement a database for this. saving your Pokemon team is a natural extension. loading other users' teams would also make a lot of sense.

I could make a team and then load it up against your team to see which has a better chance of winning.