search

keithjgrant / omnibear

A Micropub browser extension
MIT License
36 stars 8 forks source link

Release file contains all previous releases #45

Closed cweiske closed 6 years ago

cweiske commented 6 years ago

The omnibear-0.6.1.zip file contains the zips folder that contains all previous releases. This bloats it and shouldn't be.

keithjgrant commented 6 years ago

I don’t see it...?

cweiske commented 6 years ago

https://github.com/keithjgrant/omnibear/archive/0.6.2.zip

unzip -l omnibear-0.6.2.zip 
Archive:  omnibear-0.6.2.zip
b740b524b44555956998611dece6d14495cec28c
  Length      Date    Time    Name
---------  ---------- -----   ----
[...]
        0  2017-11-28 21:20   omnibear-0.6.2/zips/
   152182  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.3.0.zip
   165948  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.4.0.zip
   166062  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.4.1.zip
   166207  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.4.2.zip
  1944858  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.5.0.zip
   292335  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.5.1.zip
   292411  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.5.2.zip
   292408  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.5.3.zip
   291738  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.6.0.zip
   124092  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.6.1.zip
    51237  2017-11-28 21:20   omnibear-0.6.2/zips/omnibear-0.6.2.zip
---------                     -------
  4409166                     82 files
cweiske commented 6 years ago

You probably should mark zips/ as export-ignore in .gitattributes - see https://www.git-scm.com/docs/gitattributes#_creating_an_archive and https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/

keithjgrant commented 6 years ago

Oh, interesting. Archives are feature I'm not familiar with. I’ve just been using the zips themself. I'll have to read up on this.