keithjgrant / omnibear

A Micropub browser extension
MIT License
36 stars 8 forks source link

Update package-lock.json #57

Closed Zegnat closed 6 years ago

Zegnat commented 6 years ago

I was trying to set-up from the repository today and had issues installing the dependencies. Odd errors about missing files and unmet dependencies everywhere.

After removing the package-lock.json file everything installed like a charm.

Looking at my diff, some dependencies had never resolved to a URL in the repo’s lock file. The lock file is also still for version 0.7.0 of Omnibear. I feel like it has somehow gotten out of date with your actual package.json.

Zegnat commented 6 years ago

After rm -rf node_modules package-lock.json (possibly my favourite node debugging command :wink:) doing npm install followed by npm run build I seem to get a functioning extension. But…

I also get a few warnings pertaining to micropub-helper (ping @grantcodes):

> omnibear@1.0.0 build /Users/martijn/Sources/omnibear
> webpack --config webpack.prod.js

Hash: dedf1fb3ffbd3b641d58
Version: webpack 2.7.0
Time: 6546ms
                   Asset       Size  Chunks             Chunk Names
             icon-32.png  779 bytes          [emitted]
                index.js    66.7 kB       0  [emitted]  index
                 page.js    45.1 kB       2  [emitted]  page
  fonts/jaldi-bold.woff2    13.4 kB          [emitted]
   fonts/lato-bold.woff2    14.1 kB          [emitted]
fonts/lato-regular.woff2    13.9 kB          [emitted]
            icon-128.png    2.68 kB          [emitted]
             icon-16.png  419 bytes          [emitted]
           background.js    22.8 kB       1  [emitted]  background
             icon-48.png    1.05 kB          [emitted]
             icon-64.png    1.31 kB          [emitted]
                icon.svg    1.31 kB          [emitted]
              index.html  322 bytes          [emitted]
           manifest.json  718 bytes          [emitted]
                page.css  231 bytes          [emitted]
              styles.css    7.77 kB          [emitted]
   [0] ./~/preact/dist/preact.js 23.5 kB {0} [built]
   [1] ./src/util/utils.js 1.52 kB {0} {1} [built]
   [3] ./src/util/micropub.js 723 bytes {0} {1} [built]
  [11] ./~/micropub-helper/src/main.js 15.5 kB {0} {1} [built]
  [16] ./src/util/url.js 1.79 kB {1} [built]
  [18] ./src/util/draft.js 860 bytes {0} [built]
  [19] ./src/util/settings.js 1.54 kB {0} [built]
  [20] ./src/background/authentication.js 2.16 kB {1} [built]
  [22] ./src/page/entry.js 3.04 kB {2} [built]
  [23] ./src/background.js 2.92 kB {1} [built]
  [37] ./src/index.js 368 bytes {0} [built]
  [38] ./src/page.js 1.22 kB {2} [built]
  [39] ./src/page/dom.js 1.32 kB {2} [built]
  [40] ./~/microformat-shiv/microformat-shiv.js 110 kB {2} [built]
  [41] ./~/parse-uri/index.js 994 bytes {1} [built]
    + 27 hidden modules

WARNING in ./~/micropub-helper/src/main.js
9:4-25 "export 'FormData' (imported as 'dependencies') was not found in './dependencies'

WARNING in ./~/micropub-helper/src/main.js
10:20-41 "export 'FormData' (imported as 'dependencies') was not found in './dependencies'

WARNING in ./~/micropub-helper/src/main.js
12:4-26 "export 'DOMParser' (imported as 'dependencies') was not found in './dependencies'

WARNING in ./~/micropub-helper/src/main.js
13:21-43 "export 'DOMParser' (imported as 'dependencies') was not found in './dependencies'

WARNING in ./~/micropub-helper/src/main.js
15:4-20 "export 'URL' (imported as 'dependencies') was not found in './dependencies'

WARNING in ./~/micropub-helper/src/main.js
16:15-31 "export 'URL' (imported as 'dependencies') was not found in './dependencies'

It doesn’t seem to break anything. But I also have no clue where this is coming from. If some node developer knows more, I’d love to learn.

keithjgrant commented 6 years ago

I’ve updated the package-lock file. Let me know if you have any more troubles.

I’ve seen the warnings you mention, and they’re coming from micropub-helper. I’m note exactly sure what the issue is internally there.