keithjgrant / omnibear

A Micropub browser extension
MIT License
36 stars 8 forks source link

Omnibear errors when auth error happens #82

Open cweiske opened 5 years ago

cweiske commented 5 years ago

When trying to sign in with commentpara.de, an error happens - but Omnibear does not say which, because it fails when displaying the error.

On Chromium 72, the error is:

TypeError: Cannot set property 'textContent' of null

at this code:

                case "fetch-token-error":
                    !function(e) {
                        if (t) {
                            var r = document.getElementById("status-heading")
                              , i = document.getElementById("status-paragraph");
                            r.textContent = "Error fetching token from token endpoint",
                            i.textContent = e.message

On Firefox 64 I get this error:

Unchecked lastError value: Error: paragraph is null (authentication.js:25:8)

but without any source locations.

So it seems that the "status-paragraph" is not there anymore on https://omnibear.com/auth/success/ , while status-heading still exists.


Omnibear itself removes it in page.js:

// hide paragraph used by old versions of Omnibear


(The underlying error from micropub-helper is "The me values did not match").

cweiske commented 4 years ago

Still happens with Chromium 77 and Omnibear 1.2.0