search

keithmancuso / craft-menus

A simple but powerful menus plugin for Craft CMS built with a custom element type
51 stars 10 forks source link

Menus plugin breaks the Settings on Craft 2.5.2715 #12

Open echantigny opened 8 years ago

echantigny commented 8 years ago

I'm testing the 2.5 beta and noticed that the plugin is break the settings dialog boxes by making the buttons invisible to the user. If I disable the plugin, everything goes back to normal. screen shot 2015-11-06 at 2 34 02 pm

ryansnowden commented 8 years ago

Same for me. JS error in the console:

Uncaught SyntaxError: Invalid regular expression: /(^|.)Garnish670893443(.|$)/: Stack Overflow Uncaught RangeError: Maximum call stack size exceeded

ryansnowden commented 8 years ago

This is due to some css in the settings.html file

{% set hideSave %}
.buttons {
    display:none;
}

#settings-newmenucontainer.buttons {
    display:block;
}
{% endset %}

{# {% includeCss hideSave %} #}

It seems unnecessary so I just commented it out.

echantigny commented 8 years ago

If its a piece of required css for some reason in the plugin, we should find a way to be more precise than just .buttons. I'll investigate a bit more if I have time. Thanks

ryansnowden commented 8 years ago

Saw no reason for it, besides, perhaps legacy.

On 9 Nov 2015, at 10:23 PM, echantigny notifications@github.com wrote:

If its a piece of required css for some reason in the plugin, we should find a way to be more precise than just .buttons. I'll investigate a bit more if I have time. Thanks

— Reply to this email directly or view it on GitHub https://github.com/familiar-studio/craft-menus/issues/12#issuecomment-155077284.

auralon commented 8 years ago

Would be nice to see the necessary patch issued as a pull request, merged and then tagged and released.

keithmancuso commented 8 years ago

Hey guys, sorry for the radio silence on this. We're been hard at work on other projects but im working on some updates to this as we speak.

This issue was because we were trying to hide the default "Save" button on the settings page since there are not settings to save there... but it stopped working in 2.5 anyways.

Should be able to post an update this week and sorry again for not being responsive sooner.

boborchard commented 8 years ago

Nothing has happened, so I opened a PR against this plugin here: https://github.com/familiar-studio/craft-menus/pull/15