bump dependencies and jekyll version

[amyspark]

Hey @keithmifsud , I've bumped this gem's Jekyll version so that it is usable with the alpha of v4. I've also updated nokogiri and bundler.

Let me know if there's any problems!

[keithmifsud]

Hi @amyspark thank you for your contribution :smile: Unfortunately, the build tests are failing and thus I cannot merge the changes. Kindly fix the issues and resubmit.

[amyspark]

@keithmifsud, your .travis.yml asks for bundler v2, but the gemspec uses bundler 1.6. Can I bump the version or should I edit Travis CI to use bundler v1?

[keithmifsud]

Please bump the version on gemspec so that Travis can test for breaking changes. Thank you :)

*Keith Mifsud - *Software Engineer

w: keith-mifsud.me a: Fastolff House, 30, Regent Street, Great Yarmouth, Norfolk. U.K.

https://facebook.com/mifsudKeith https://twitter.com/keithmifsud

On Tue, 2 Apr 2019 at 13:03, L. E. Segovia notifications@github.com wrote:

@keithmifsud https://github.com/keithmifsud, your .travis.yml asks for bundler v2, but the gemspec uses bundler 1.6. Can I bump the version or should I edit Travis CI to use bundler v1?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/keithmifsud/jekyll-target-blank/pull/35#issuecomment-478965631, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-cCGtqHs1lvuWSODCvbPtGZCkXxgNXks5vc0cdgaJpZM4cWzEG .

[keithmifsud]

Thanks once again. Sorry to ask, but I am out and cannot pull the PR. Can you please update the version number of this library to 1.1.2? Once done we can merge it. Thank you.

[amyspark]

@keithmifsud, it's done!

[cristianocasella]

sorry, there is any update with this PR? I would like to update nokogiri on my Jekyll installation to fix this: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-11068

Thanks

[kenchan0130]

@cristianocasella As this project does not seem to be maintained, I forked this project and started maintenance. https://github.com/kenchan0130/jekyll-target-blank

I hope it will help you.

[amyspark]

Ping @keithmifsud ?

[keithmifsud]

Hi @amyspark thank you for your PR... I'm looking into it as we speak :) I really appreciate your help. Sorry I've been away from this library for a while and even Jekyll. Not sure about Jekyll's BC. Should this be a v2 release or just a minor version?

[keithmifsud]

I think I'll release v2.0 for Jekyll 4 as it might not work on older Jekyll's versions.

[keithmifsud]

sorry, there is any update with this PR? I would like to update nokogiri on my Jekyll installation to fix this: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-11068

Thanks

Hi @cristianocasella I will now release v1.2 for the security issue and then 2.0 for Jekyll 4 which will include the security fix.

[keithmifsud]

Hi @amyspark thanks a lot for your help on this PR :) I moved the cnages to another PR due to some issues with rubocop. I am releasing this now.

[kenchan0130]

@keithmifsud If you can, I can help you maintain your library. I continued maintenance here. I don't want the maintenance to be parallel in multiple repositories.

Please consider my proposal.

[keithmifsud]

Hi @kenchan0130

Certainly, I think it is a great idea and I greatly appreciate it :smile:

I can give you appropriate access, however, we will still require my approval for PRs until we find another suitable contributor. Basically, the aim is to stay in focus with the plugin's intention, maintain the coding standards and also the dev process standards (sem ver etc..).

Let me know and thank you once again!

[keithmifsud]

Hi @kenchan0130 , if you submit your PR, I assure that I will look into within 24hrs.

[kenchan0130]

@keithmifsud I'm relieved to hear that. I'll move issues and PRs that were coming to my repository.