Enhancements? - Githubissues

mikeobrien commented 9 years ago

So I'm moving to gulp and was going to migrate my grunt-nunit-runner task but saw you already had one out there. Wanted to see if you were open to a PR with some enhancements instead of creating yet another gulp nunit plugin. Here's what I had in mind:

[X] Add build script with test, lint and watch.
[X] Add Travis CI integration.
[x] Add a TeamCity reporter.
[x] Add support for multi options e.g. include, exclude and privatebinpath.
[x] Add the ability to 1) omit the explicit nunit path entirely and rely on it being in the PATH and 2) just supply the path to the bin folder but not explicitly specify the filename. I have a platform flag in the Grunt task that goes along with both these to chose the x86 or anycpu version of nunit; defaults to anycpu.
[x] Document all the config options in the README (Like this). The NUnit docs on the options are more prose than a list which makes it difficult to quickly scan them.

Anyways, this is a lot of stuff so if you want pass on a PR for these I totally understand.

mikeobrien commented 9 years ago

Oh yeah, other thing was setting up a Travis CI build to lint and run the tests.

keithmorris commented 9 years ago

hey @mikeobrien , I 'm definitely open to it. Unfortunately I don't have a ton of time to spend on it right now. If you'd like to add some features, I'd love to see what you can add. I'd just want to make sure that the api stays backwards compatible as I've got a few jobs running on it and I know quite a few other folks do as well.

xavierzwirtz commented 9 years ago

I have roughly 50 Jenkins jobs set up using the current api, stability in the api would be nice.

On November 10, 2014 10:00:01 PM Keith Morris notifications@github.com wrote:

hey @mikeobrien , I 'm definitely open to it. Unfortunately I don't have a ton of time to spend on it right now. If you'd like to add some features, I'd love to see what you can add. I'd just want to make sure that the api stays backwards compatible as I've got a few jobs running on it and I know quite a few other folks do as well.

Reply to this email directly or view it on GitHub: https://github.com/keithmorris/gulp-nunit-runner/issues/5#issuecomment-62498918

mikeobrien commented 9 years ago

@keithmorris yeah, no problem, I can do all the work and submit a PR. Thanks for getting back to me so quickly, trying to get this knocked out by tomorrow.

@keithmorris & @VoiceOfWisdom absolutely, will not mod the API other than adding two options for TeamCity and platform.

mikeobrien commented 9 years ago

Mods are complete, created a new PR.

keithmorris commented 9 years ago

All enhancements have been released as of version 0.4.0

mikeobrien commented 9 years ago

Awesome, thanks Keith! Just updated our build to the latest and we're seeing test results in TC yay!

keithmorris / gulp-nunit-runner

Enhancements? #5