search

keithmorris / node-dotenv-extended

A module for loading .env files and optionally loading defaults and a schema for validating all values are present.
MIT License
111 stars 24 forks source link

Feature/update deps remove node 6 support #32

Closed keithmorris closed 4 years ago

keithmorris commented 4 years ago

I wanted to update all package dependencies as there were potential security issues in some of the required packages. Some of these updated dependencies no longer support Node < 8 and as such, the library has been set to have the node engine requirement at Node >= 8. Travis test script has removed Node 6 and added Node 12.

This seems acceptable to me as Node < 8 is no longer supported and Node 8 will only be supported through 2019-12.31.

Although there is no change in functionality, I have bumped the version to 3.0.0 in case anyone is using the 2.x.x version in Node 6/7 it will not cause the library to fail as long as their package.json file indicates the "^2.7.0" syntax to lock their version at the 2.x.x release.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 73437c4698c02e50f65cce9a81bc3ce39d5e0b6a on feature/update_deps_remove_node_6_support into 7d9c77d74ce22a18fcab99fe7b39b3a2f7233afe on develop.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 427876a7fc0cf6f74ab875faf9a00b58539ca674 on feature/update_deps_remove_node_6_support into 5eb5058f12534485f23c203c4b6cc92a84706f0a on develop.

keithmorris commented 4 years ago

@niftylettuce Would love your thoughts on this PR.

niftylettuce commented 4 years ago

I don't think we should drop support for Node 6 to be honest. There is not a valid reason why we should suddenly drop the support.

niftylettuce commented 4 years ago

Like other packages out there, we should be as far back compatible as possible.