Update Asura Scans Base URL

keiyoushi / extensions-source

Source code of extensions for Tachiyomi/Mihon and variants.

https://keiyoushi.github.io/

Apache License 2.0

1.51k stars 350 forks source link

Update Asura Scans Base URL #2790

Closed StephenLeeY closed 1 month ago

StephenLeeY commented 1 month ago

Asura Scans extension is broken. Any asuratoon URLs automatically redirect to home page of new asuracomic.net homepage, causing null pointer exceptions and broken sources.

Checklist:

[x] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[x] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[x] Have removed web_hi_res_512.png when adding a new extension

Norsze commented 1 month ago

Am I the only one without any issues? Did you turn on dynamic URLs in the extension settings?

StephenLeeY commented 1 month ago

Am I the only one without any issues? Did you turn on dynamic URLs in the extension settings?

I have dynamic URLs turned on. The issue started when I decided to uninstall and reinstall the extension, after which all my current sources started having the issue above. I can see that the URL is redirecting when viewing through webview.

Norsze commented 1 month ago

Try migrating them from Asura to Asura

StephenLeeY commented 1 month ago

Try migrating them from Asura to Asura

This doesn't work, they're considered the same source when I attempt to migrate, and going through with it still does not fix the issue. If I turn off dynamic URLs, they're considered different sources, but now both sources don't work as they still have the redirect issue.

Norsze commented 1 month ago

Also did you actually test this? Or did you just checkmark everything without a clue of what you're doing? Cause your changes are currently not sufficient or doing what you checkmarked as having done

StephenLeeY commented 1 month ago

Fixed some of the issues, apologies this is my first time looking through this codebase so I thought I covered the checklist.

StephenLeeY commented 1 month ago

Actually just saw a contributor posted the same PR, so will close this one to expedite fix