search

keizerworks / invoicen

Invoicen is a simple invoice generator for freelancers and small businesses. It is a self hostable web application that can be used to generate invoices and download PDFs
MIT License
11 stars 13 forks source link

[FEAT] :sparkles: skeleton for nav loading #16

Closed aayushchugh closed 1 week ago

aayushchugh commented 1 week ago

Description

Our navbar takes time to load because of Next Image and dynamic theme configuration. We need to create a skeleton loading indicator.

Anything else?

https://ui.shadcn.com/docs/components/skeleton

Are you willing to submit PR?

No

tushar-daiya commented 1 week ago

It loads for me instantly.. even if you want a skeleton I am willing to submit a PR

Prithviraj2003 commented 1 week ago

Screenshot 2024-11-04 155112

image

I am using bg-gray-300 for the skeleton any better colour suggestion for it ?

aayushchugh commented 1 week ago

@Prithviraj2003 are you using skeleton from shadcn/ui or did you build your custom one?

Prithviraj2003 commented 1 week ago

I am using Shadcn/ui

aayushchugh commented 1 week ago

@Prithviraj2003 use bg-muted as colour, everything else looks great. Thanks for your efforts.

bg-muted syncs with dark and light theme

Prithviraj2003 commented 1 week ago

@Prithviraj2003 use bg-muted as colour, everything else looks great. Thanks for your efforts.

bg-muted syncs with dark and light theme

Sure